diff --git a/client/src/assets/player/peertube-plugin.ts b/client/src/assets/player/peertube-plugin.ts index f03553184..451b4a161 100644 --- a/client/src/assets/player/peertube-plugin.ts +++ b/client/src/assets/player/peertube-plugin.ts @@ -11,6 +11,7 @@ import { } from './peertube-player-local-storage' import { PeerTubePluginOptions, UserWatching, VideoJSCaption } from './peertube-videojs-typings' import { isMobile } from './utils' +import { SettingsButton } from './videojs-components/settings-menu-button' const Plugin = videojs.getPlugin('plugin') @@ -31,7 +32,8 @@ class PeerTubePlugin extends Plugin { private menuOpened = false private mouseInControlBar = false - private readonly savedInactivityTimeout: number + private mouseInSettings = false + private readonly initialInactivityTimeout: number constructor (player: videojs.Player, options?: PeerTubePluginOptions) { super(player) @@ -40,8 +42,7 @@ class PeerTubePlugin extends Plugin { this.videoDuration = options.videoDuration this.videoCaptions = options.videoCaptions this.isLive = options.isLive - - this.savedInactivityTimeout = player.options_.inactivityTimeout + this.initialInactivityTimeout = this.player.options_.inactivityTimeout if (options.autoplay) this.player.addClass('vjs-has-autoplay') @@ -108,13 +109,13 @@ class PeerTubePlugin extends Plugin { if (this.userWatchingVideoInterval) clearInterval(this.userWatchingVideoInterval) } - onMenuOpen () { - this.menuOpened = false + onMenuOpened () { + this.menuOpened = true this.alterInactivity() } onMenuClosed () { - this.menuOpened = true + this.menuOpened = false this.alterInactivity() } @@ -207,26 +208,43 @@ class PeerTubePlugin extends Plugin { } private listenControlBarMouse () { - this.player.controlBar.on('mouseenter', () => { + const controlBar = this.player.controlBar + const settingsButton: SettingsButton = (controlBar as any).settingsButton + + controlBar.on('mouseenter', () => { this.mouseInControlBar = true this.alterInactivity() }) - this.player.controlBar.on('mouseleave', () => { + controlBar.on('mouseleave', () => { this.mouseInControlBar = false this.alterInactivity() }) + + settingsButton.dialog.on('mouseenter', () => { + this.mouseInSettings = true + this.alterInactivity() + }) + + settingsButton.dialog.on('mouseleave', () => { + this.mouseInSettings = false + this.alterInactivity() + }) } private alterInactivity () { - if (this.menuOpened) { - this.player.options_.inactivityTimeout = this.savedInactivityTimeout + if (this.menuOpened || this.mouseInSettings || this.mouseInControlBar || this.isTouchEnabled()) { + this.setInactivityTimeout(0) return } - if (!this.mouseInControlBar && !this.isTouchEnabled()) { - this.player.options_.inactivityTimeout = 1 - } + this.setInactivityTimeout(this.initialInactivityTimeout) + this.player.reportUserActivity(true) + } + + private setInactivityTimeout (timeout: number) { + (this.player as any).cache_.inactivityTimeout = timeout + this.player.options_.inactivityTimeout = timeout } private isTouchEnabled () { diff --git a/client/src/assets/player/videojs-components/settings-menu-button.ts b/client/src/assets/player/videojs-components/settings-menu-button.ts index 75a5c6904..6de390f4d 100644 --- a/client/src/assets/player/videojs-components/settings-menu-button.ts +++ b/client/src/assets/player/videojs-components/settings-menu-button.ts @@ -144,7 +144,7 @@ class SettingsButton extends Button { } showDialog () { - this.player().peertube().onMenuOpen(); + this.player().peertube().onMenuOpened(); (this.menu.el() as HTMLElement).style.opacity = '1' diff --git a/client/src/sass/player/peertube-skin.scss b/client/src/sass/player/peertube-skin.scss index 96d752699..876fdf968 100644 --- a/client/src/sass/player/peertube-skin.scss +++ b/client/src/sass/player/peertube-skin.scss @@ -158,6 +158,7 @@ body { background: linear-gradient(rgba(0, 0, 0, 0.2), rgba(0, 0, 0, 0.6)); box-shadow: 0 -15px 40px 10px rgba(0, 0, 0, 0.2); text-shadow: 0 0 2px rgba(0, 0, 0, 0.5); + transition: visibility 0.3s, opacity 0.3s !important; > button:first-child { @include margin-left($first-control-bar-element-margin-left);