interesting
/
PeerTube
mirror of https://github.com/Chocobozzz/PeerTube.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Remove unnecessary image check in video upload

This commit is contained in:
Chocobozzz 2018-07-16 16:51:17 +02:00
parent 1f6824c958
commit 019e475072
No known key found for this signature in database
GPG Key ID: 583A612D890159BE
1 changed files with 0 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
server/middlewares/validators/videos.ts
View File

@ -51,7 +51,6 @@ const videosAddValidator = getCommonVideoAttributes().concat([
logger.debug('Checking videosAdd parameters', { parameters: req.body, files: req.files }) logger.debug('Checking videosAdd parameters', { parameters: req.body, files: req.files })
if (areValidationErrors(req, res)) return if (areValidationErrors(req, res)) return
if (areErrorsInVideoImageFiles(req, res)) return
if (areErrorsInScheduleUpdate(req, res)) return if (areErrorsInScheduleUpdate(req, res)) return
const videoFile: Express.Multer.File = req.files['videofile'][0] const videoFile: Express.Multer.File = req.files['videofile'][0]
@ -101,7 +100,6 @@ const videosUpdateValidator = getCommonVideoAttributes().concat([
logger.debug('Checking videosUpdate parameters', { parameters: req.body }) logger.debug('Checking videosUpdate parameters', { parameters: req.body })
if (areValidationErrors(req, res)) return if (areValidationErrors(req, res)) return
if (areErrorsInVideoImageFiles(req, res)) return
if (areErrorsInScheduleUpdate(req, res)) return if (areErrorsInScheduleUpdate(req, res)) return
if (!await isVideoExist(req.params.id, res)) return if (!await isVideoExist(req.params.id, res)) return
@ -252,25 +250,6 @@ export {
// --------------------------------------------------------------------------- // ---------------------------------------------------------------------------
function areErrorsInVideoImageFiles (req: express.Request, res: express.Response) {
// Files are optional
if (!req.files) return false
for (const imageField of [ 'thumbnail', 'preview' ]) {
if (!req.files[ imageField ]) continue
const imageFile = req.files[ imageField ][ 0 ] as Express.Multer.File
if (imageFile.size > CONSTRAINTS_FIELDS.VIDEOS.IMAGE.FILE_SIZE.max) {
res.status(400)
.json({ error: `The size of the ${imageField} is too big (>${CONSTRAINTS_FIELDS.VIDEOS.IMAGE.FILE_SIZE.max}).` })
.end()
return true
}
}
return false
}
function areErrorsInScheduleUpdate (req: express.Request, res: express.Response) { function areErrorsInScheduleUpdate (req: express.Request, res: express.Response) {
if (req.body.scheduleUpdate) { if (req.body.scheduleUpdate) {
if (!req.body.scheduleUpdate.updateAt) { if (!req.body.scheduleUpdate.updateAt) {